Page 12 of 12 FirstFirst ... 2101112
Results 111 to 118 of 118

Thread: Theme repository reviews

  1. #111
    greenshady's Avatar
    greenshady is offline Here For The Peanuts
    Join Date
    Jan 2009
    Posts
    170

    Default

    Three buddies and I get together and create a theme. We want to upload it. Should we create a separate WP.org account just for that theme (and possibly future themes)? Or, can we all somehow be listed as the theme author as with plugins? Personally, I don't want to manage yet another account, especially for a site that I already have an account on.

    Also, this isn't really a hypothetical question. This is something that *will* be happening at some point in the near future.

    Not having SVN access is an extremely big deal in this case too.

    Edit: By "listed as the theme authors" I mean that we all have access to the theme admin and have it shown on our profile pages. I don't really care if we're all listed on the theme page as the theme author.
    Last edited by greenshady; 08-27-2010 at 08:40 PM.

  2. #112
    chipbennett's Avatar
    chipbennett is offline WordPress Legend
    Join Date
    Feb 2009
    Location
    St. Louis, MO
    Posts
    1,997

    Default

    Quote Originally Posted by greenshady View Post
    While these aren't deprecated calls, I don't see much point in using bloginfo() over the get_* functions. I think I remember Westi saying it's best to use these at one point, but I can't confirm that.

    bloginfo( 'stylesheet_directory' )
    get_stylesheet_directory()

    bloginfo( 'stylesheet_url' )
    get_stylesheet_directory_uri()

    bloginfo( 'template_directory' )
    get_template_directory()

    bloginfo( 'template_url' )
    get_template_directory_uri()

    bloginfo( 'text_direction' )
    is_rtl() ? 'rtl' : 'ltr'

    bloginfo( 'language' ) and get_locale() are similar but used differently. The former calls the latter and replaces the underscore with a hyphen. I suppose it depends on what it might be used for.
    I'll add those, too. I was mainly drafting the proof-of-concept, and didn't have time to look for the rest...
    WP TurnKey - Turn-Key WordPress installation and maintenance services
    WordPress user since 2005 | @chip_bennett | chipbennett.net | cbnet Plugins

  3. #113
    Frumph is offline Hello World
    Join Date
    Sep 2009
    Posts
    34

    Default

    Also take note, that some functions call other functions to get data, some people want to use the path of least resistance and often times just want to use the less functions being called.

    Now mind you I haven't pathed everything but i'm sure some of those calls to path locations one is better then the other just because of the calls it makes to get the data, and don't forget the define's as well that are made. Me? I create a central variable location for the rest of my code to get the values from so it doesn't keep running the same thing to get the same path structure over and over.

    - Phil

  4. #114
    Frumph is offline Hello World
    Join Date
    Sep 2009
    Posts
    34

    Default

    Quote Originally Posted by greenshady View Post
    Three buddies and I get together and create a theme. We want to upload it. Should we create a separate WP.org account just for that theme (and possibly future themes)? Or, can we all somehow be listed as the theme author as with plugins? Personally, I don't want to manage yet another account, especially for a site that I already have an account on.
    Isn't there a 'contributors:' that you can put in the style.css like there is for plugins? .. if not maybe the author: can be comma delimited.. if you put the 'username' you have on wordpress.org as the author it creates a link to all of your themes, example: http://wordpress.org/extend/themes/comicpress where since I put the author of the comicpress account which uploaded it.

    .. We use a central account for comicpress to upload, checking

    Nope, it doesn't take contributors nor does it actually use the author: line, it just takes the username from whoever uploaded, bummer.

    Might be something to ask Otto or someone to incorporate to allow a Contributors thing

    - Phil

  5. #115
    Frumph is offline Hello World
    Join Date
    Sep 2009
    Posts
    34

    Default

    Quote Originally Posted by greenshady View Post
    While these aren't deprecated calls, I don't see much point in using bloginfo() over the get_* functions. I think I remember Westi saying it's best to use these at one point, but I can't confirm that.

    bloginfo( 'stylesheet_directory' )
    get_stylesheet_directory()

    bloginfo( 'stylesheet_url' )
    get_stylesheet_directory_uri()

    bloginfo( 'template_directory' )
    get_template_directory()

    bloginfo( 'template_url' )
    get_template_directory_uri()

    bloginfo( 'text_direction' )
    is_rtl() ? 'rtl' : 'ltr'

    bloginfo( 'language' ) and get_locale() are similar but used differently. The former calls the latter and replaces the underscore with a hyphen. I suppose it depends on what it might be used for.
    It appears get_bloginfo() actually calls the get_template_* stuff so really if I wanted to be making faster running code I wouldnt want to call bloginfo and use get_template_directory_* get_stylesheet_directory_* on their own. ( along with that I would want to make a global at the top of the functions.php that assigns it so that it a variable to use for the rest of the code, but thats memory management at that point. )

  6. #116
    Frumph is offline Hello World
    Join Date
    Sep 2009
    Posts
    34

    Default

    More along the lines of the get_bloginfo rather then get_template_* get_stylesheet_* I just filed a bug

    http://core.trac.wordpress.org/ticket/14720

    Basically it's not passing the proper information anyways. So we shouldn't even go there at all right now.

  7. #117
    Frumph is offline Hello World
    Join Date
    Sep 2009
    Posts
    34

    Default

    Apparently i'm wrong, it's not a bug, bloginfo('template_directory') and bloginfo('template_directory_uri') are both the same return values and not a path at all, so we need to make a specification in the codex that makes sure it's clear they are the both thing and use get_template_directory() and get_stylesheet_directory() for paths to check if say file_exists and such.

    ^ doesn't make sense to me that they return the same URI string, but hey, whatever.

  8. #118
    hakre's Avatar
    hakre is offline Here For The Peanuts
    Join Date
    Jun 2010
    Posts
    129

    Default

    I know that Semiologic is doing that, but I don't like the approach that everybody is doing it for themselves. I like the approach of the package manager we have in the various linux derivates. You can add multiple repositories. I therefore opened a ticket in trac that is about that feature: Configuration of Plugin and Theme Repository/ies (Ticket #13067).
    hakre on wordpress (clicking this all three minutes help to keep the cache fresh - thanks)

Page 12 of 12 FirstFirst ... 2101112

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •